dogeystamp/chess_inator
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

perf: make_unlinked takes reference instead of ownership

Browse Source
This commit is contained in:
dogeystamp 2024-10-22 18:09:32 -04:00
parent 00bfbd7fbc
commit 17bec263d9
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/movegen.rs
View File

@ -83,8 +83,8 @@ impl Move {
/// Make move, without setting up the backlink for unmake. /// Make move, without setting up the backlink for unmake.
/// ///
/// Call this directly when making new positions that are dead ends (won't be used further). /// Call this directly when making new positions that are dead ends (won't be used further).
fn make_unlinked(self, old_pos: BoardState) -> BoardState { fn make_unlinked(self, old_pos: &BoardState) -> BoardState {
let mut new_pos = old_pos; let mut new_pos = *old_pos;
// reset en passant // reset en passant
new_pos.ep_square = None; new_pos.ep_square = None;
@ -245,7 +245,7 @@ impl Move {
/// Old position is saved in a backlink. /// Old position is saved in a backlink.
/// No checking is done to verify even pseudo-legality of the move. /// No checking is done to verify even pseudo-legality of the move.
pub fn make(self, old_node: &Rc<Node>) -> Rc<Node> { pub fn make(self, old_node: &Rc<Node>) -> Rc<Node> {
let pos = self.make_unlinked(old_node.pos); let pos = self.make_unlinked(&old_node.pos);
Node { Node {
prev: Some(Rc::clone(old_node)), prev: Some(Rc::clone(old_node)),
pos, pos,
@ -671,7 +671,7 @@ impl LegalMoveGen for Node {
}) })
.filter(|mv| { .filter(|mv| {
// disallow moving into check // disallow moving into check
let new_pos = mv.make_unlinked(self.pos); let new_pos = mv.make_unlinked(&self.pos);
!is_check(&new_pos, self.pos.turn) !is_check(&new_pos, self.pos.turn)
}) })
} }
@ -704,8 +704,7 @@ mod tests {
fn test_bitboard_capture() { fn test_bitboard_capture() {
let board = BoardState::from_fen("8/8/8/8/8/8/r7/R7 w - - 0 1").unwrap(); let board = BoardState::from_fen("8/8/8/8/8/8/r7/R7 w - - 0 1").unwrap();
let mv = Move::from_uci_algebraic("a1a2").unwrap(); let mv = Move::from_uci_algebraic("a1a2").unwrap();
// there's an assertion within make move that should let new_pos = mv.make_unlinked(&board);
let new_pos = mv.make_unlinked(board);
use std::collections::hash_set::HashSet; use std::collections::hash_set::HashSet;
use Piece::*; use Piece::*;
@ -1354,14 +1353,14 @@ mod tests {
3, 3,
), ),
]; ];
for (fen, expected_values, debug_limit_depth) in test_cases { for (fen, expected_values, _debug_limit_depth) in test_cases {
let root_node = Rc::new(Node::new(BoardState::from_fen(fen).unwrap())); let root_node = Rc::new(Node::new(BoardState::from_fen(fen).unwrap()));
for (depth, expected) in expected_values.iter().enumerate() { for (depth, expected) in expected_values.iter().enumerate() {
eprintln!("running perft depth {depth} on position '{fen}'"); eprintln!("running perft depth {depth} on position '{fen}'");
#[cfg(debug_assertions)] #[cfg(debug_assertions)]
{ {
if depth > debug_limit_depth { if depth > _debug_limit_depth {
break; break;
} }
} }